nova/glacier
1
0
Fork 0
Code Issues 4 Pull requests Releases 3 Activity Actions

fix(cli): add spawn_blocking around update command #11

Merged
nova merged 1 commit from fix/debug-update into main 2026-08-02 04:17:13 +00:00
Conversation 0 Commits 1 Files changed 2 +9 -2
nova commented 2026-08-02 03:37:16 +00:00
Owner
Copy link

self_update being synchronous, I called it as-is. This works in release mode.

However, in debug mode, tokio crashes because of a runtime drop. Adding tokio::task::spawn_blocking around the call fixes it, as intended for blocking operations.

`self_update` being synchronous, I called it as-is. This works in release mode. However, in debug mode, `tokio` crashes because of a runtime drop. Adding `tokio::task::spawn_blocking` around the call fixes it, as intended for blocking operations.
nova self-assigned this 2026-08-02 03:37:16 +00:00
fix(cli): added spawn_blocking around update command
All checks were successful
CI / Lint (pull_request) Successful in 48s
Details
CI / Build (pull_request) Successful in 1m16s
Details
CI / Test (pull_request) Successful in 1m22s
Details
914f9683cd
nova merged commit 7112f5683d into main 2026-08-02 04:17:13 +00:00
nova deleted branch fix/debug-update 2026-08-02 04:17:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nova
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nova/glacier!11
No description provided.